FEAT(client): Introduced new mumble API to link and unlink #6336

mryamac · 2024-02-12T19:56:12Z

This patch introduces a new API to link and unlink the given channels to the given link ids.

Checks

My commits follow the commit guidelines

Krzmbrzl

Thinking about the feature introduced here, I believe it would benefit from completing the interface w.r.t. linked channels:

Allow to link/unlink an arbitrary amount of channels with a single function call (e.g. take an array of channel IDs instead of a pair of them)
Add function to get the set of linked channels a given channel is in
Optionally, add a convenience function to check whether a given pair of channels is linked with each other.
What do you think?

plugins/MumblePlugin.h

mryamac · 2024-02-13T09:38:38Z

Thinking about the feature introduced here, I believe it would benefit from completing the interface w.r.t. linked channels:

Allow to link/unlink an arbitrary amount of channels with a single function call (e.g. take an array of channel IDs instead of a pair of them)

Add function to get the set of linked channels a given channel is in

Optionally, add a convenience function to check whether a given pair of channels is linked with each other.
What do you think?

I think we don't need such functions for the first case, multiple link and unlink channels. Let me explain why I am feeling like this. How can we handle this in case of an exception? If one of the channels does not exist, what should I do? Should I link others, or should I send an error? This decision belongs to people who call API. Am I right?

For the second case, the get function is ok for me. How about the set function if the same case happens like the above?
Instead of a set function, we may write a clear function to remove all linked channels. How about this one?

In the third case, checking whether the pair of channels is linked or not is also ok for me.

Krzmbrzl · 2024-02-13T15:07:12Z

If one of the channels does not exist, what should I do? Should I link others, or should I send an error? This decision belongs to people who call API. Am I right?

No - if the user provides an invalid channel, the API call returns an error and does nothing.

How about the set function if the same case happens like the above?

I'm I afraid I can't quite follow your meaning here 👀

Instead of a set function, we may write a clear function to remove all linked channels. How about this one?

I wasn't proposing a set function, I was proposing a function that returns the set (in the mathematical sense) of channels that are all linked together. Specifically that set to which a given channel belongs (which can be the empty set - aka an empty array).
The clear-function that you propose should be equivalent to the unlink function that I suggested, no?

mryamac · 2024-02-13T17:46:18Z

If one of the channels does not exist, what should I do? Should I link others, or should I send an error? This decision belongs to people who call API. Am I right?

No - if the user provides an invalid channel, the API call returns an error and does nothing.

Ok

How about the set function if the same case happens like the above?

I'm I afraid I can't quite follow your meaning here 👀

Sorry about that. I need to be clearer. I thought the set was another function, so, I mean that channel does not exist for a given channel list. This question is no more valid with your explanation.

Instead of a set function, we may write a clear function to remove all linked channels. How about this one?

I wasn't proposing a set function, I was proposing a function that returns the set (in the mathematical sense) of channels that are all linked together. Specifically that set to which a given channel belongs (which can be the empty set - aka an empty array). The clear-function that you propose should be equivalent to the unlink function that I suggested, no?

My proposed method is not exactly the same as the unlink function. The proposed method, clear, won't take the channels list. It unlinks all linked channels. Actually, this can be done using get and unlink methods, but it's simpler usage. It is up to you, the clear method is not necessary.

Krzmbrzl · 2024-02-14T10:16:51Z

My proposed method is not exactly the same as the unlink function. The proposed method, clear, won't take the channels list. It unlinks all linked channels. Actually, this can be done using get and unlink methods, but it's simpler usage. It is up to you, the clear method is not necessary.

I have the feeling that this function would probably be unusable on general servers as there might be linked channels that are completely unrelated to what the plugin is doing but if that plugin would call this clear function, those links would be gone as well. That doesn't seem desirable to me 🤔

plugins/MumblePlugin.h

Krzmbrzl

All new API functions are missing the mumble_connection_t argument (as the second argument - see other functions)

plugins/MumblePlugin.h

src/mumble/API_v_1_x_x.cpp

plugins/MumblePlugin.h

Krzmbrzl · 2024-02-23T16:18:11Z

All new API functions are missing the mumble_connection_t argument (as the second argument - see other functions)

☝️
that seems to have gone missing in the mass of review comments :)

This one too:

Finally, there should be a new function inside ServerHandler that can transmit all to-be-linked channels in a single message. Otherwise, we risk running into the server's (per default rather strict) rate limiter and request messages will get dropped.

mryamac · 2024-04-06T08:47:24Z

All new API functions are missing the mumble_connection_t argument (as the second argument - see other functions)

☝️ that seems to have gone missing in the mass of review comments :)

This one too:

Finally, there should be a new function inside ServerHandler that can transmit all to-be-linked channels in a single message. Otherwise, we risk running into the server's (per default rather strict) rate limiter and request messages will get dropped.

Could you check the latest changes?

Switch to using an unsigned integer as channel ID and rename member variables to no longer include their type as part of the name (and make names more meaningful in general). Additionally, some Qt containers were replaced with std ones.

The v3 actions are based on Node 16 and are therefore deprecated.

…plates

We had two level-one headlines. Add a document-level headline and intro text (without an intro text it would be quite empty). Indent every over headline by one level to have correct, consistent levels. The intro text provides general context even without specific technical knowledge about the document context. Although it does not introduce the connection between Git and commit.

When the user is muted and/or suppressed in Mumble, there is no reason to keep the audio stream running (except for the mute cue). Disabling/suspending the pipewire stream has the advantage of allowing upstream nodes to suspend themselves as well. When using resource-heavy audio filters like e.g. DeepFilterNet, this can save significant amounts of CPU time.

Docker documentation should be on our website (administrator/hoster documentation) or our [mumble-docker] repository. This repository /docs/ should only contain developer documentation and scoped to this source/main project. --- PR mumble-voip#5838 commit 81bb8f7 removed the docker-compose.yml file in this repository. The `murmur.ini` reference is outdated. It was moved and renamed to `umble-server-ini` The `database` path is outdated ('murmur' name). --- Replaces/Closes PR mumble-voip#6387 which intended to fix the documentation. [mumble-docker]: https://github.com/mumble-voip/mumble-docker/

Currently translated at 93.2% (2157 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.2% (2156 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Oğuz Ersen <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Currently translated at 89.2% (2064 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Moritz Schirmer <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translation: Mumble/Mumble Client

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Polish translation Currently translated at 100.0% (2312 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Matthaiks <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/pl/ Translation: Mumble/Mumble Client

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update French translation Currently translated at 95.3% (2205 of 2312 strings) TRANSLATION: Update French translation Currently translated at 89.3% (2066 of 2312 strings) TRANSLATION: Update French translation Currently translated at 89.3% (2066 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: programutox <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fr/ Translation: Mumble/Mumble Client

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Chinese (Simplified) translation Currently translated at 89.2% (2064 of 2312 strings) TRANSLATION: Update Chinese (Simplified) translation Currently translated at 89.2% (2064 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: deluxghost <[email protected]> Co-authored-by: 大王叫我来巡山 <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/zh_Hans/ Translation: Mumble/Mumble Client

The inventor dedicated the design to the public domain, all patents lapsed intentionally. Comments only, no code change. Fixes mumble-voip#6403

Previously, tarballs created from our script would contain user/group info from the host system. This could be verified by running: ``tar -tvf <file>`` This commit adds an explicit tarinfo filter to drop username and groupname automatically.

The script had the following issues: * Typo in the match regex string * Wrong enumeration of match groups * No support for commits without merge commit I also added a hotfix for backport commits which did not conform to the pattern (sorry)

Drops icons/flags. Deletes mention from license dialog, and helper script. Adds submodule to 3rdparty/flag-icons. Adjusts CMakefile to pick up new path. Adds license (MIT) to license dialog. Fixes mumble-voip#6411

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Spanish translation Currently translated at 91.8% (2123 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.0% (2221 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Paco Rivière <[email protected]> Co-authored-by: Pedro Antonio Acebes Bayón <[email protected]> Co-authored-by: Schorsch <[email protected]> Co-authored-by: janne ojanperä <[email protected]> Co-authored-by: nortio <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/it/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Currently translated at 99.5% (2302 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.1% (2223 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Spanish translation Currently translated at 91.8% (2123 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.0% (2221 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Mæve Rey <[email protected]> Co-authored-by: Paco Rivière <[email protected]> Co-authored-by: Pedro Antonio Acebes Bayón <[email protected]> Co-authored-by: Schorsch <[email protected]> Co-authored-by: janne ojanperä <[email protected]> Co-authored-by: nortio <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/it/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Currently translated at 87.0% (2013 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: duracellh <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ru/ Translation: Mumble/Mumble Client

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Spanish translation Currently translated at 91.8% (2123 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.0% (2221 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Paco Rivière <[email protected]> Co-authored-by: Pedro Antonio Acebes Bayón <[email protected]> Co-authored-by: Schorsch <[email protected]> Co-authored-by: janne ojanperä <[email protected]> Co-authored-by: nortio <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/it/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Currently translated at 94.2% (2180 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Spanish translation Currently translated at 91.8% (2123 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.0% (2221 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Joshua <[email protected]> Co-authored-by: Paco Rivière <[email protected]> Co-authored-by: Pedro Antonio Acebes Bayón <[email protected]> Co-authored-by: Schorsch <[email protected]> Co-authored-by: janne ojanperä <[email protected]> Co-authored-by: nortio <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/it/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Spanish translation Currently translated at 91.8% (2123 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update German translation Currently translated at 96.0% (2221 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 92.9% (2150 of 2312 strings) TRANSLATION: Update Finnish translation Currently translated at 90.1% (2084 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.4% (2068 of 2312 strings) TRANSLATION: Update Italian translation Currently translated at 89.1% (2062 of 2312 strings) TRANSLATION: Update Catalan translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update German translation Currently translated at 95.1% (2201 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 100.0% (2312 of 2312 strings) TRANSLATION: Update Turkish translation Currently translated at 93.6% (2165 of 2312 strings) Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: Paco Rivière <[email protected]> Co-authored-by: Pedro Antonio Acebes Bayón <[email protected]> Co-authored-by: Schorsch <[email protected]> Co-authored-by: janne ojanperä <[email protected]> Co-authored-by: nortio <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/ca/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/de/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/es/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/fi/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/it/ Translate-URL: https://hosted.weblate.org/projects/mumble/mumble-client/tr/ Translation: Mumble/Mumble Client

Krzmbrzl · 2024-05-21T16:53:15Z

@mryamac why did you delete the branch?

mryamac · 2024-05-21T17:55:18Z

I will add two more API functions, and I thought a fresh start would be nice.

Krzmbrzl · 2024-05-21T19:11:46Z

Ah okay - so a new PR will be coming at some point in the future? Then ignore my comment :D

Krzmbrzl added client feature-request This issue or PR deals with a new feature labels Feb 13, 2024

Krzmbrzl reviewed Feb 13, 2024

View reviewed changes

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

mryamac force-pushed the new_mumble_api_link branch 2 times, most recently from 284e0ad to a399c45 Compare February 13, 2024 09:55

Krzmbrzl reviewed Feb 14, 2024

View reviewed changes

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

plugins/MumblePlugin.h Outdated Show resolved Hide resolved

mryamac force-pushed the new_mumble_api_link branch 3 times, most recently from d776a95 to 3a32dbc Compare February 15, 2024 10:31

mryamac requested a review from Krzmbrzl February 16, 2024 10:48

Krzmbrzl requested changes Feb 18, 2024

View reviewed changes

mryamac marked this pull request as draft February 19, 2024 06:43

mryamac force-pushed the new_mumble_api_link branch from 3a32dbc to 12f9168 Compare February 23, 2024 08:05

mryamac requested a review from Krzmbrzl February 23, 2024 08:18

mryamac force-pushed the new_mumble_api_link branch 5 times, most recently from 003bcd7 to 8cae373 Compare February 24, 2024 05:16

mryamac marked this pull request as ready for review February 24, 2024 07:03

mryamac marked this pull request as draft April 6, 2024 08:45

mryamac marked this pull request as ready for review April 6, 2024 08:45

mryamac force-pushed the new_mumble_api_link branch 2 times, most recently from 88b6501 to 6c10b51 Compare April 6, 2024 12:18

Krzmbrzl and others added 25 commits May 21, 2024 11:43

REFAC(server): Refactor WhisperTarget struct

060c905

Switch to using an unsigned integer as channel ID and rename member variables to no longer include their type as part of the name (and make names more meaningful in general). Additionally, some Qt containers were replaced with std ones.

CI(github-actions): Upgrade to Node 20 actions

2583caa

The v3 actions are based on Node 16 and are therefore deprecated.

DOCS(ice): Add Channel.temporary read-only notice

db375c7

MAINT(github): Drop obsolete, archived forums web-link from issue tem…

b1ebd48

…plates

FEAT(client): Add ReNameNoise as a replacement for RNNoise

bc90461

MAINT: The OCB design is in the public domain

b636bbe

The inventor dedicated the design to the public domain, all patents lapsed intentionally. Comments only, no code change. Fixes mumble-voip#6403

FEAT(server): Add error code when UDP socket binding fails

13c01d0

MAINT: Drop user and group info from tarball

c3cc4c1

Previously, tarballs created from our script would contain user/group info from the host system. This could be verified by running: ``tar -tvf <file>`` This commit adds an explicit tarinfo filter to drop username and groupname automatically.

MAINT: Fix generate changelog script

69d624d

The script had the following issues: * Typo in the match regex string * Wrong enumeration of match groups * No support for commits without merge commit I also added a hotfix for backport commits which did not conform to the pattern (sorry)

FIX(ui): Replace Emoji One icons with MIT licensed flag-icons

547b713

Drops icons/flags. Deletes mention from license dialog, and helper script. Adds submodule to 3rdparty/flag-icons. Adjusts CMakefile to pick up new path. Adds license (MIT) to license dialog. Fixes mumble-voip#6411

mryamac closed this May 21, 2024

mryamac deleted the new_mumble_api_link branch May 21, 2024 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEAT(client): Introduced new mumble API to link and unlink #6336

FEAT(client): Introduced new mumble API to link and unlink #6336

mryamac commented Feb 12, 2024 •

edited

Loading

Krzmbrzl left a comment •

edited

Loading

mryamac commented Feb 13, 2024

Krzmbrzl commented Feb 13, 2024

mryamac commented Feb 13, 2024 •

edited

Loading

Krzmbrzl commented Feb 14, 2024

Krzmbrzl left a comment

Krzmbrzl commented Feb 23, 2024 •

edited

Loading

mryamac commented Apr 6, 2024

Krzmbrzl commented May 21, 2024

mryamac commented May 21, 2024

Krzmbrzl commented May 21, 2024

FEAT(client): Introduced new mumble API to link and unlink #6336

FEAT(client): Introduced new mumble API to link and unlink #6336

Conversation

mryamac commented Feb 12, 2024 • edited Loading

Checks

Krzmbrzl left a comment • edited Loading

Choose a reason for hiding this comment

mryamac commented Feb 13, 2024

Krzmbrzl commented Feb 13, 2024

mryamac commented Feb 13, 2024 • edited Loading

Krzmbrzl commented Feb 14, 2024

Krzmbrzl left a comment

Choose a reason for hiding this comment

Krzmbrzl commented Feb 23, 2024 • edited Loading

mryamac commented Apr 6, 2024

Krzmbrzl commented May 21, 2024

mryamac commented May 21, 2024

Krzmbrzl commented May 21, 2024

mryamac commented Feb 12, 2024 •

edited

Loading

Krzmbrzl left a comment •

edited

Loading

mryamac commented Feb 13, 2024 •

edited

Loading

Krzmbrzl commented Feb 23, 2024 •

edited

Loading